Add ARIA heading role to crate search results #11999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DataTriny
force-pushed
the
crate-row-heading
branch
from
fcb4b4b to
c709991
Compare
Turbo87
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11759
Making name and version appear as headings inside search results list is important for screen-reader users. It allows for jumping between elements of a list by pressing a single key on the keyboard.
Level 2 headings seem to be more appropriate given the current site structure.
I went with ARIA roles and attributes rather than
h2tag so as to not mess up the visual appearance. If using the semantic tag is preferred, please provide the right CSS rules as I am not able to verify this myself.